Differential D17237

KTextEditor::ViewPrivate: S&R
ClosedPublic
Actions

Authored by loh.tar on Nov 29 2018, 4:17 PM.

Details

Reviewers
cullmann
Group Reviewers
KTextEditor
Commits
R39:ad4ec47eb73a: KTextEditor::ViewPrivate: S&R
Summary
  • 'm_doc->' => 'doc()->'
  • 'm_viewInternal->m_cursor' => 'cursorPosition()'

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Nov 29 2018, 4:17 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 29 2018, 4:17 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Nov 29 2018, 4:17 PM
loh.tar added a comment.EditedNov 29 2018, 4:20 PM

I can split it if you like in two diff

  • 'm_doc->' => 'doc()->' ~100 hits, perhaps not the best idea? A search for doc() has 24 hits (without this patch)
  • 'm_viewInternal->m_cursor' => 'cursorPosition()' ~10 hits

Next would be look for inline candidates, look for S&R in KateViewInternal

Edit: Wow, that was scary! The highlighting here is wrong. It has compiled.
Is these "Context not available." bad because you can't add code comments in this case?

Edit2: Um, no. It's possible by click on line number

cullmann accepted this revision.Nov 30 2018, 8:45 AM

Looks ok as is, thanks!

This revision is now accepted and ready to land.Nov 30 2018, 8:45 AM
Closed by commit R39:ad4ec47eb73a: KTextEditor::ViewPrivate: S&R (authored by loh.tar, committed by cullmann). · Explain WhyNov 30 2018, 8:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateview.cpp (198 lines)

Diff 46534

View Options

src/view/kateview.cpp

Loading...