Differential D17236

Align NetworkPacket.hasPayload with desktop
ClosedPublic
Actions

Authored by eduisters on Nov 29 2018, 3:39 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:4dd651b386ea: Align NetworkPacket.hasPayload with desktop
Summary

On desktop NetworkPacket.hasPayload() tests m_payloadSize
On android NetworkPacket.hasPayload() tests mPayload

This patch makes android also test mPayloadSize to make things more consistent

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
align_np_has_payload_with_desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5534
Build 5552: arc lint + arc unit
eduisters created this revision.Nov 29 2018, 3:39 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 29 2018, 3:39 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Nov 29 2018, 3:39 PM
albertvaka accepted this revision.Nov 29 2018, 10:19 PM
This revision is now accepted and ready to land.Nov 29 2018, 10:19 PM
eduisters updated this revision to Diff 46532.Nov 30 2018, 7:39 AM

Rebased onto master

Closed by commit R225:4dd651b386ea: Align NetworkPacket.hasPayload with desktop (authored by eduisters). · Explain WhyNov 30 2018, 7:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46532

View Options

src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java

Loading...
View Options

src/org/kde/kdeconnect/NetworkPacket.java

Loading...