Differential D17228

Fixing a crash caused by QCustomPlot's replot method in a concurrent thread
ClosedPublic
Actions

Authored by lancaster on Nov 29 2018, 3:46 AM.

Details

Reviewers
mutlaqja
Commits
R321:de5eb0259b7b: Fixing a crash caused by QCustomPlot's replot method in a concurrent thread
Summary

Fixing an intermittent crash caused by QCustomPlot's replot method
being used in a concurrent thread The reason for it is because Qt does not
support painting to GUI elements in any thread but the GUI thread and
QCustomPlot's replot method includes a repaint. So if the Histogram is
currently visible and construct histogram is run in a concurrent thread,
the program would call replot and crash.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lancaster created this revision.Nov 29 2018, 3:46 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 29 2018, 3:46 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
lancaster requested review of this revision.Nov 29 2018, 3:46 AM
mutlaqja accepted this revision.Nov 29 2018, 5:03 AM
This revision is now accepted and ready to land.Nov 29 2018, 5:03 AM
Closed by commit R321:de5eb0259b7b: Fixing a crash caused by QCustomPlot's replot method in a concurrent thread (authored by lancaster, committed by mutlaqja). · Explain WhyNov 29 2018, 5:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstars/fitsviewer/fitstab.cpp (3 lines)

Diff 46446

View Options

kstars/fitsviewer/fitstab.cpp

Loading...