Differential D17184

Explicitly import Qt 5.7's QtQuick for Connections.enabled
ClosedPublic
Actions

Authored by heikobecker on Nov 27 2018, 11:05 AM.

Details

Reviewers
vkrause
broulik
Commits
R1007:b867de409b04: Explicitly import Qt 5.7's QtQuick for Connections.enabled
Summary

It was introduced in that version. Fixes 'qrc:/DateTimeEdit.qml:60
"Connections.enabled" is not available in QtQuick 2.5.' when trying
to start itinerary, preventing its main window from appearing.

Test Plan

itinerary's main window comes up

Diff Detail

Repository
R1007 Itinerary - Travel Assistance Application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Nov 27 2018, 11:05 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 27 2018, 11:05 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
heikobecker requested review of this revision.Nov 27 2018, 11:05 AM
broulik accepted this revision.Nov 27 2018, 1:38 PM
broulik added a subscriber: broulik.

Had to do the same in various other places, e.g. f328668559cc56a8a32f52932873554af8b4f5da

This revision is now accepted and ready to land.Nov 27 2018, 1:38 PM
vkrause accepted this revision.Nov 27 2018, 1:58 PM

Makes sense, just surprised I didn't see this fail here.

broulik added a comment.Nov 27 2018, 1:59 PM

Qt 5.12 seems to be somewhat stricter with that, only started happening there.

Closed by commit R1007:b867de409b04: Explicitly import Qt 5.7's QtQuick for Connections.enabled (authored by heikobecker). · Explain WhyNov 27 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/app/DateTimeEdit.qml (2 lines)

Diff 46312

View Options

src/app/DateTimeEdit.qml

Loading...