Private Static consts
ClosedPublic

Authored by rizzitello on Sun, Nov 25, 2:55 AM.

Diff Detail

Repository
R232 AtCore
Branch
staticPrivate
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5364
Build 5382: arc lint + arc unit
rizzitello requested review of this revision.Sun, Nov 25, 2:55 AM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Sun, Nov 25, 2:56 AM
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
rizzitello updated this revision to Diff 46173.Sun, Nov 25, 3:08 AM
rizzitello edited the summary of this revision. (Show Details)
  • Fix variable names
laysrodrigues accepted this revision.Sun, Nov 25, 2:25 PM

looks good to me!

This revision is now accepted and ready to land.Sun, Nov 25, 2:25 PM
patrickelectric requested changes to this revision.Sun, Nov 25, 4:38 PM
patrickelectric added inline comments.
src/core/temperature.cpp
41

alphabetic order

57

you can use auto here.

111–113

msgString = QString::fromLatin1(msg) to avoid the usage of fromLatin1

This revision now requires changes to proceed.Sun, Nov 25, 4:38 PM
rizzitello updated this revision to Diff 46215.Sun, Nov 25, 5:33 PM
rizzitello marked 3 inline comments as done.
  • Patrick Suggestions
rizzitello added inline comments.Sun, Nov 25, 5:34 PM
src/core/temperature.cpp
57

It will not build if auto is used. Compiler complains about redefined variable.

patrickelectric accepted this revision.Mon, Nov 26, 11:16 PM
This revision is now accepted and ready to land.Mon, Nov 26, 11:16 PM
laysrodrigues accepted this revision.Tue, Nov 27, 2:06 PM
rizzitello closed this revision.Tue, Nov 27, 8:57 PM