Don't reverse order of files opened from the command line
AbandonedPublic

Authored by gmolteni on Nov 24 2018, 10:48 PM.

Details

Reviewers
cfeck
zetazeta
ngraham
Group Reviewers
Kate
Summary

When you do kate file1 file2 file3, it will open tabs
in same order, file1 file2 file3.
In case of having kate opened, invoking it again with
kate file4 file5 file6 final result on tabs shall be
file4 file5 file6 file1 file2 file3

BUG: 397913

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5337
Build 5355: arc lint + arc unit
gmolteni created this revision.Nov 24 2018, 10:48 PM
Restricted Application added a project: Kate. · View Herald TranscriptNov 24 2018, 10:48 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gmolteni requested review of this revision.Nov 24 2018, 10:48 PM
ngraham requested changes to this revision.Nov 24 2018, 11:19 PM
ngraham added a reviewer: Kate.

Thanks, this works great for both use cases! The code change itself looks sane, there are just a few style and formatting nitpicks I have. See the inline comments.

kate/kateapp.cpp
178

This comment should describe why you're doing this, not just the bug. Something like // Reverse the order here so the new tabs are opened in same order as the files were passed in on the command line

457

Unnecessary/unrelated whitespace change

kate/main.cpp
419

See above

This revision now requires changes to proceed.Nov 24 2018, 11:19 PM
gmolteni marked an inline comment as done.Nov 25 2018, 12:15 AM

Thanks, this works great for both use cases! The code change itself looks sane, there are just a few style and formatting nitpicks I have. See the inline comments.

Sorry, but I made another mistake here, i did not notice when doing arc diff I was in master branch.
I tried to fix with git reset but it did not work. I will do the commit again and abandon this revision to
work clean. Sorry again.

You don't have to do that. Just download this patch from Phabricator onto its own branch with arc patch D17144. Then you can keep working when you're on the branch it creates, which should be called arcpatch-D17144.

Thanks, this works great for both use cases! The code change itself looks sane, there are just a few style and formatting nitpicks I have. See the inline comments.

It continues at here https://phabricator.kde.org/D17145

gmolteni abandoned this revision.Nov 25 2018, 12:29 AM

Abandoned to start work clean (in the Diff 46162 it was not clean the difference after before on sourcecode).
New version is https://phabricator.kde.org/D17145