commit a7ba6eb000 regressed duplicates showing in the
Quick Open view.
Details
Details
- Reviewers
gregormi cullmann - Group Reviewers
Kate - Commits
- R40:74eda4bc5874: Fix regression: duplicates were shown again
Diff Detail
Diff Detail
- Repository
- R40 Kate
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Sorry for the regression.
I wonder, when I now look at katequickopenmodel.h:
struct ModelEntry {
QUrl url; // used for actually opening a selected file (local or remote) QString fileName; // display string for left column QString filePath; // display string for right column bool bold; // format line in bold text or not
};
if it would now make sense to use the 'url' to find duplicates instead of 'filePath'. The former is more stable than the latter.
Comment Actions
I have no issues with changing the algo to use the url, the question is: should other parts use the url, too?
In any case, I apply this quickfix now.