Details
- Reviewers
- None
- Commits
- R322:15f71296ab55: checks for alpha value too
Diff Detail
- Repository
- R322 KGeography
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I feel like this needs a bit more of a commit log than "checks for alpha value too", i've beeen trying to understand what the new code does and i don't think i do
Yup, I may be add some more cleaning, too (I thought I had not committed all the changed lines, especially those in comment).
- Mail original -----
De: "Albert Astals Cid" <noreply@phabricator.kde.org>
À: lauranger@free.fr
Cc: kde-edu@kde.org, "david narvaez" <david.narvaez@computer.org>, aleixpol@kde.org
Envoyé: Vendredi 23 Novembre 2018 00:41:24
Objet: D17110: checks for alpha value tooView Revision aacid added a comment.
I feel like this needs a bit more of a commit log than "checks for
alpha value too", i've beeen trying to understand what the new code
does and i don't think i doREPOSITORY
R322 KGeography
REVISION DETAIL
https://phabricator.kde.org/D17110To: lauranger
Cc: aacid, kde-edu, narvaez, apol
Check for alpha value too
reports, the tool did not warn about PNG image
having color not matched in kgm file although RGB triple was foundable
because of alpha channel not full (255).
This commits adds this checking.
| tools/colorchecker.py | ||
|---|---|---|
| 85 | Since this is going to cause an exit, can we have a more descriptive message of what is wrong? | |
Can you make it python3 compatible? The code before your patch works fine with python3, but once patched complains about syntax.
one fix at least is that print needs () now, not sure if there may be other issues.