Connect to contextMenu clicked callback only once
ClosedPublic
Actions

Authored by broulik on Nov 22 2018, 2:59 PM.

Details

Reviewers

davidedmundson
fvogt

Group Reviewers

Plasma

Commits

Summary

The connection isn't bound to the menu entry but global causing the handler to fire multiple times, one more for every device added.

Test Plan

Unpaired and paired my phone repeatedly, sent a link to it, it only opened once on my phone now

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Nov 22 2018, 2:59 PM

This revision is now accepted and ready to land.Nov 22 2018, 3:35 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			extension/extension.js (41 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46017			Nov 22 2018, 2:58 PM	★	★
Diff 2	46021	31d57c5	R856:453b420ceb42e8d03dfa9b58310280cf9a0eeb40	Nov 22 2018, 3:36 PM	★	★