Differential D17047

Use correct icon in Edit Profile settings panel
AbandonedPublic
Actions

Authored by EspadaV8 on Nov 20 2018, 1:20 PM.

Details

Reviewers
konsole-devel
hindenburg
ngraham
Group Reviewers
Konsole
Summary

The current folder-open icon is different from all the other icons used
in Konsole so it makes sense to update this to use the same one.

BUG: 348446

Test Plan

Edit a profile and check the folder icon next to 'Initial directory' option. It
should now look the same as e.g. the icon on the Configure Konsole -> TabBar
panel.

Diff Detail

Repository
R319 Konsole
Branch
348446-use-correct-icon-in-edit-profile-settings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5180
Build 5198: arc lint + arc unit
EspadaV8 created this revision.Nov 20 2018, 1:20 PM
Restricted Application added a project: Konsole. · View Herald TranscriptNov 20 2018, 1:20 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
EspadaV8 requested review of this revision.Nov 20 2018, 1:20 PM
hindenburg added a comment.Nov 20 2018, 2:00 PM

I think the icons are correct as-is, though their may be some other issue w/ the themes as detailed in the bug report. The 'Initial Dir' is asking for a folder so folder-open seems correct. The "User user-defined stylesheet' is asking for a file so the document-open seems OK.

ngraham requested changes to this revision.Nov 20 2018, 11:29 PM
ngraham added a subscriber: ngraham.

That's correct, this is a Breeze icon theme bug. I've moved the bug report to the correct location. The right fix is there, not in Konsole.

This revision now requires changes to proceed.Nov 20 2018, 11:29 PM
EspadaV8 abandoned this revision.Nov 21 2018, 10:51 AM

M'kay, that sounds like a better solution. It did feel off making this change, but 'fixing' it in breeze would absolutely be better.

Revision Contents
Changeset List

PathPackages
Msrc/EditProfileDialog.cpp (2 lines)

Diff 45885

View Options

src/EditProfileDialog.cpp

Loading...