Although I would still very much like Konsole to support this, with the changes made to how Konsole does splitting, this patch no long applies cleanly and after spending a little bit of time on it I was unable to get the code to work correctly without segfaulting, so I'm closing this for now.

Any update on having this reviewed? If it's unlikely to make it into Konsole would it be possible to still get a review of the code since I'm curious if it could be improved in any way. I was thinking too that this could be added as either checkbox option or as an extra command line parameter if having it as the default behaviour wasn't wanted.

@davidedmundson this isn't what this is trying to provide. I have a global shortcut configured for "Toggle Background Window" (in my case Meta+Return). I have Konsole start at launch (konsole --background-mode). This prevents Konsole from quitting after the last tab has been closed.

That looks like a hack and not really the intended use of the application name. Restarting to make the change also seems hacky. If @hindenburg is happy with that change perhaps open a new revision?

@glenncoombs I just had a look at doing that and it doesn't work out well. You can remove it but to do it I needed to remove the details from the KAboutData section (first and second lines below). Replacing konsole on the first line and Konsole for the @title does remove the suffix, but the about screen then loses the information. Calling app->setApplicationDisplayName(QString("")); after that (or before) doesn't do anything.

@ngraham Is there anyway to progress this and to decide if this change (or something like it) could be merged into Konsole? I spoke briefly with @hein on the #kde-devel channel on IRC and they didn't see any reason why Yakuake features couldn't be merged into Konsole itself (just that no one has done it before). They did mention that they'd like to see the Konsole KPart functionality improved but I'm not in a position to be able to know exactly what would need to be done to implement those changes.

• Use hasDarkBackground to decide if we should alter background colour

• Use hasDarkBackground to decide if we should alter background colour

@hindenburg Sounds good. I'll change it to use hasDarkBackground and also change the altered maxValue to 127 (since > 127 would then be a 'light' background colour).

M'kay, that sounds like a better solution. It did feel off making this change, but 'fixing' it in breeze would absolutely be better.

Allow small colour changes when varying dark backgrounds

This will only make changes to backgrounds that are completely black. Setting the background to rgb(1, 0, 0) won't look any different normally, but will also make this appear 'broken'. I was thinking of using hasDarkBackground but that has a much larger range of values (anything < 127). If that's only I can change this to use that method instead.

Sorry, I tried to update D16482 using arc but it's created a new revision instead. I wanted to update the previous one so that it used the --background-mode flag instead of adding a new option. The update should now mean that if Konsole is started with --background-mode it will behave like Yakuake does so that if the last tab is closed, the window is hidden and a new default session is started for when the window it shown again.

I was originally using Yakuake but that has an issue where it doesn't respect the setting to open new tabs in the current working directory.

@ngraham Looking there and I don't have any Konsole shortcuts defined. I'm running Fedora F28 so perhaps it's not a standard thing (or it's been removed)? What should that shortcut do? Does it launch a new instance of Konsole when it's entered or does it bring an existing instance to the foreground?

I've checked the global settings for Konsole and the only entry there is for Toggle Background Window which is what I'm using now (although it was configured as Ctrl+Shift+F12 and I have added my own as Meta+Return). I checked the shortcuts inside Konsole too and didn't see anything that looked related. Do you know what the name of the shortcut is?

I didn't know about Ctrl+Alt+t. I'll give it a go and see if that works as needed.

I did not use arc, but I shall for the next one.

Didn't realise that the summary here would become part of the git commit so moving the text into a comment

After talking to stikonas on IRC I've updated the patch with -U9999 to add more context