Make FindExiv2.cmake work with exiv 0.27.
ClosedPublic
Actions

Authored by krop on Nov 20 2018, 10:02 AM.

Details

Reviewers

kde-buildsystem
kde-frameworks-devel

Commits

Summary

In exiv2 >= 0.27, the version is not defined in version.hpp but in exv_conf.h.
The module now:

The module was also refreshed to use the modern CMake syntax and follow our
CMake policies.

Test Plan

exiv2 0.26 and 0.27 are found.

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

krop requested review of this revision.Nov 20 2018, 10:02 AM

Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake

In D17040#362883, @rempt wrote:

Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake

yep, if accepted, I'll copy the modules in kfilemetadata, koko, libkexiv2, krename, kphotoalbum and krita. No idea why we have so many copies around.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 10:32 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			cmake/FindExiv2.cmake (177 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45870	37b9e80		Nov 20 2018, 10:02 AM	★	★
Diff 2	46541	a057005	R260:6f4e08953736cfd0c282dd36fd72cf1fd2b18810	Nov 30 2018, 10:30 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8148d99c1217	394ca43ed0c4	37b9e8052723	Christophe Giboudeaux	Make FindExiv2.cmake work with exiv 0.27. (Show More…)	Nov 20 2018, 9:59 AM