[kcm] Expose interface to control output property retention
Changes PlannedPublic

Authored by romangg on Nov 18 2018, 11:45 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This adds two radio buttons to the kcm, that allow to change the output
property retention of the output currently being modified.

The default value is global property retention.

Test Plan

Autotest passes.

Diff Detail

Repository
R104 KScreen
Branch
0controlKcm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5114
Build 5132: arc lint + arc unit
romangg created this revision.Nov 18 2018, 11:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2018, 11:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Nov 18 2018, 11:45 PM
romangg planned changes to this revision.EditedNov 18 2018, 11:49 PM
romangg edited the summary of this revision. (Show Details)

This diff contains some fixes, that need to go into earlier diffs in this patch series.

Visually, let's follow the existing formlayout style in the KCM and put the label to the left of the radio buttons rather than using a group box. Also, the two radio button labels shouldn't end with periods.

I'll admit just looking at the new UI, it's not entirely clear what either of the options do. Can you help me understand? Thanks Roman!

I'll admit just looking at the new UI, it's not entirely clear what either of the options do. Can you help me understand? Thanks Roman!

I replied to your mail to the plasma-devel thread. We can continue the discussion there. Maybe we find an alternative solution for the radio buttons better suited for what we want to communicate to the user.