Fix running kdoctools-install autotest without kdoctools installed
ClosedPublic

Authored by habacker on Nov 17 2018, 6:25 PM.

Diff Detail

Repository
R238 KDocTools
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5051
Build 5069: arc lint + arc unit
habacker created this revision.Nov 17 2018, 6:25 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptNov 17 2018, 6:25 PM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
habacker requested review of this revision.Nov 17 2018, 6:25 PM
aacid added a comment.Nov 17 2018, 6:54 PM

Cool test passes now, BUT see comment

KF5DocToolsMacros.cmake
205

We need to figure a way to fix it without removing this line, since this is a fix i did to fix parallel builds (see git log). Or we need to find another way to fix parallel builds :D

habacker updated this revision to Diff 45690.Nov 17 2018, 7:56 PM
  • fix parallel builds
habacker marked an inline comment as done.Nov 17 2018, 7:57 PM
aacid accepted this revision.Nov 17 2018, 9:34 PM

Works, I'm not a kdoctools *real* expert so maybe you want to wait for someone else to approve, but i'd say just commit, i mean i don't think it's worse than what we have now and the test will pass which is always a good thing :)

This revision is now accepted and ready to land.Nov 17 2018, 9:34 PM
This revision was automatically updated to reflect the committed changes.