to get the box chars to be drawn correctly we need to turn on high
quality antialiasing in qpainter. in addition only turn it on if
antialiasing is enabled.
lastly qpainter.save()/restore() is called very often, so try to avoid
that if it isn't necessary.
BUG: 401463
cat tests/boxes.txt
old:
new:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
uhm, never mind this for now. I didn't notice that it actually just didn't draw any antialiasing on the corners. but I guess that also explains why the current antialiasing doesn't work very well.
I tested a bit more, the problem is that drawArc and drawLine look very different with antialiasing on.
So to get the hardcoded line chars to look good with antialiasing they basically have to be remade (I started using QPainterPath, but it's pretty boring work without much in return).
But I can push this patch (without the HighQualityAntialiasing bit, it just worked because it's obsolete and QPainter ignored it), it removes some state thrashing in QPainter (so a tiny performance improvement).
The arc patch is moving files - can you re-upload?
rename from src/TerminalDisplay.cpp
rename to TerminalDisplay.cpp
OK so this is for when 'Use Line characters contained in in Font' is disabled. I see a big improvement then.