move kcrash link to dolphin app (which is the effective user)
ClosedPublic

Authored by sitter on Nov 15 2018, 1:46 PM.

Details

Summary

to successfully use kcrash when linking with as-needed (which is a default
flag on many linux distros) one also needs to call KCrash::initialize.
this call happens in the app's main.cpp. as such the kcrash link target
on the dolphinprivate library doesn't do anything for dolphinprivate but
only kicks into action for dolphin itself.
to avoid confusion and make it clear that kcrash is only initialized in the
application scope the KF5::Crash link target is now on the application
target, not the library target.

(this makes no difference in the output, kcrash was still correctly linked
via dolphinprivate; but only for kdeinit_dolphin, dolphinprivate did
not get linked to it with as-needed)

Test Plan

builds; links as expected

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Nov 15 2018, 1:46 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 15 2018, 1:46 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
sitter requested review of this revision.Nov 15 2018, 1:46 PM
This revision is now accepted and ready to land.Nov 17 2018, 10:30 AM
This revision was automatically updated to reflect the committed changes.