Differential D16883

Add VirtualDesktops to PlasmaWindowModel
ClosedPublic
Actions

Authored by davidedmundson on Nov 14 2018, 7:32 PM.

Details

Reviewers

mart

Group Reviewers

KWin

Commits

R127:98b0ad34b68f: Add VirtualDesktops to PlasmaWindowModel

Summary

VirtualDesktops with the new plurality was added PlasmaWindowManagement,
but PlasmaWindowModel was left unchanged.

In behavioural changes, setting a window to be on all running desktops
should not mark it as being set on all desktops, they are 2 distinct
pieces of information.

Test Plan

Relevant unit test

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Nov 14 2018, 7:32 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 14 2018, 7:32 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Nov 14 2018, 7:32 PM

Harbormaster completed remote builds in B4943: Diff 45480.Nov 14 2018, 7:32 PM

update the plasma virtual desktop test at the same time

Harbormaster completed remote builds in B4945: Diff 45483.Nov 14 2018, 8:08 PM

mart accepted this revision.Nov 15 2018, 11:40 AM

This revision is now accepted and ready to land.Nov 15 2018, 11:40 AM

Closed by commit R127:98b0ad34b68f: Add VirtualDesktops to PlasmaWindowModel (authored by davidedmundson). · Explain WhyNov 15 2018, 11:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_plasma_virtual_desktop.cpp (18 lines)
M			autotests/client/test_plasma_window_model.cpp (50 lines)
M			src/client/plasmawindowmanagement.cpp (6 lines)
M			src/client/plasmawindowmodel.h (7 lines)
M			src/client/plasmawindowmodel.cpp (10 lines)
M			src/server/plasmawindowmanagement_interface.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45480	841f956		Nov 14 2018, 7:32 PM	★	★
Diff 2	45483	841f956	update the plasma virtual desktop test at the same time	Nov 14 2018, 8:08 PM	★	★
Diff 3	45512	f1c8b16	R127:98b0ad34b68f72081487e88f4348602a5aeee6f0	Nov 15 2018, 11:56 AM	★	★