This reverts commit 8388ed0603f0d04d7adde2152b077dbd29275ee3.
The commit was only a workaround for neon shipping a broken tarball.
Details
Details
- Reviewers
- None
- Group Reviewers
KDE Connect
Revert untested, but it worked fine before the commit got merged.
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- 1.3
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4939 Build 4957: arc lint + arc unit
Comment Actions
I'm wondering whether the .protocol to .json conversion is related, because it was part of the same commit.
If not, I'll just revert the QCoreApplication change.
Comment Actions
Is there some disadvantage to keeping things the way they are? From my understanding of the situation, having plugins instantiate a QApplication object is the way KIO wants things to be done (even though the particular commit which caused older plugins to break was a mistake that they have fixed). The .protocol file instead of the .json definitely seems to be the new way as well.
Comment Actions
Indeed, I just read the commit message in kcrash:
The right fix is to create a QCoreApplication in all kioslaves
So other than the wrong subject there's nothing against this commit anymore.
Sorry for the noise.