Differential D16865

Unbreak AbstractClient::setDesktop
AbandonedPublic
Actions

Authored by graesslin on Nov 13 2018, 3:05 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

setDesktop is an important internal API with a given contract: setting
the desktop to a specific desktop. It does not mean adding a desktop.
setDesktop is used by internal API such as sendClientToDesktop. The
intention of such code is pretty clear, it's not to add a client to a
desktop.

If we want additional API for setting a client to multiple desktop we
should add it, not abuse existing internal api.

Test Plan

DesktopPresenceChange test is working again

Diff Detail

Repository
R108 KWin
Branch
unbreak-set-desktop
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4906
Build 4924: arc lint + arc unit
graesslin created this revision.Nov 13 2018, 3:05 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 13 2018, 3:05 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 13 2018, 3:05 PM
zzag added a subscriber: zzag.Nov 13 2018, 3:15 PM

Doesn't D16703 fix it as well?

davidedmundson added a comment.Nov 13 2018, 4:01 PM

I was waiting to sort out a minor thing in D16704 so that we can have everything working nicely without the wayland side regressing, but I can push D16703 without too much issue.

graesslin added a comment.Nov 13 2018, 5:16 PM

Though this change is unrelated. The internal API is destroyed, this needs fixing.

graesslin abandoned this revision.Nov 13 2018, 5:20 PM

After evaluating what is now in master I can conclude that the API breakage was fixed.

Revision Contents
Changeset List

PathPackages
Mabstract_client.cpp (2 lines)

Diff 45416

View Options

abstract_client.cpp

Loading...