Allow sharing clipboard items to kdeconnect
Needs ReviewPublic

Authored by blaws on Nov 11 2018, 6:50 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch allows you to send the contents of an entry in the clipboard
to kdeconnect, then, depending on whether its a url or text entry it will
open it in the devices text editor or browser.

Diff Detail

Repository
R120 Plasma Workspace
Branch
share (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4842
Build 4860: arc lint + arc unit
blaws created this revision.Nov 11 2018, 6:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 11 2018, 6:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
blaws requested review of this revision.Nov 11 2018, 6:50 PM
broulik added inline comments.
applets/clipboard/contents/ui/ClipboardItemDelegate.qml
32

What's this for?

applets/clipboard/contents/ui/DelegateToolButtons.qml
30

Use document - share icon

32

Give it a proper tool tip, e.g. i18n("Share")

applets/clipboard/contents/ui/Share.qml
9

Can't we just use Purpose framework for this, I'm not a huge fan of directly using KDE connect stuff here. With purpose you could also share to Pastebin and what not

blaws added inline comments.Nov 11 2018, 7:29 PM
applets/clipboard/contents/ui/ClipboardItemDelegate.qml
32

Accessing the clipboard items text from toolbuttondelegate

applets/clipboard/contents/ui/Share.qml
9

How would I do that? I'm not even sure kdeconnect supports purpose

broulik added inline comments.Nov 11 2018, 7:40 PM
applets/clipboard/contents/ui/ClipboardItemDelegate.qml
32

Just do onClicked: menuItem.share(DisplayRole) this way you also share the raw text without any of the highlighting we do in the delegate

applets/clipboard/contents/ui/Share.qml
9

It has had a purpose plug in forever. I'm at a conference right now and reviewing from my phone :D so i cannot look this up right now :/ perhaps someone else can explain this to you, I'm very sorry.

+1 for using Purpose for this

blaws added inline comments.Nov 11 2018, 8:48 PM
applets/clipboard/contents/ui/ClipboardItemDelegate.qml
32

Ah, thanks, will do that

applets/clipboard/contents/ui/DelegateToolButtons.qml
30

Sure

32

Right

apol added a subscriber: apol.Nov 12 2018, 12:46 AM

Why? Isn't the clipboard shared by its own plugin?