Differential D16772

Add new icons for root
ClosedPublic
Actions

Authored by ndavis on Nov 9 2018, 1:51 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R266:e2270613fc25: Add new icons for root
Summary

Add an icon for people that like to have Root (/) as a Places bookmark

Change the style of drive-harddisk-root to match.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
folder-root (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4786
Build 4804: arc lint + arc unit
ndavis created this revision.Nov 9 2018, 1:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 9 2018, 1:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Nov 9 2018, 1:51 AM
ndavis edited the test plan for this revision. (Show Details)Nov 9 2018, 2:01 AM
ndavis added a subscriber: VDG.Nov 9 2018, 2:09 AM
ndavis edited the test plan for this revision. (Show Details)Nov 9 2018, 3:08 AM
ndavis added a comment.Nov 9 2018, 3:25 PM

Alternative style. If I choose this style, I will also change the style of drive-harddisk-root.

ndavis retitled this revision from Add folder-root icon to Add new icons for root.Nov 9 2018, 7:27 PM
ndavis edited the summary of this revision. (Show Details)
ndavis edited the test plan for this revision. (Show Details)
ndavis updated this revision to Diff 45196.Nov 9 2018, 7:30 PM

Change style to /_. The reason for this is that / by itself looks kind of empty and it's easy to confuse the meaning with disabled or inactive, especially for drive-harddisk-root.

ngraham accepted this revision.Nov 9 2018, 9:50 PM
ngraham added a subscriber: ngraham.

Makes sense to me. Now that I see them all together, I agree that /_ is a bit better. It seems much better for the folder, and at least no worse (and probably a bit better) for the disk.

Any other VDG comments, or should we land this?

BTW, @ndavis, you're doing so much good work that I would recommend you apply for a Developer account so you can land your own patches. You can read about that here: https://community.kde.org/Infrastructure/Get_a_Developer_Account

BTW, once this goes in, I'll submit a KIO patch to use the new icon for the current Root Places Panel item. If we end up not removing it after all, we might as well use the nice new icon! :)

This revision is now accepted and ready to land.Nov 9 2018, 9:50 PM
ndavis updated this revision to Diff 45208.Nov 9 2018, 9:55 PM

Update commit message to more accurately describe the changes

ndavis updated this revision to Diff 45209.Nov 9 2018, 9:58 PM

Add symbolic version of drive-harddisk-root

ndavis added a comment.Nov 9 2018, 10:01 PM
In D16772#357086, @ngraham wrote:

Makes sense to me. Now that I see them all together, I agree that /_ is a bit better. It seems much better for the folder, and at least no worse (and probably a bit better) for the disk.

Any other VDG comments, or should we land this?

BTW, @ndavis, you're doing so much good work that I would recommend you apply for a Developer account so you can land your own patches. You can read about that here: https://community.kde.org/Infrastructure/Get_a_Developer_Account

BTW, once this goes in, I'll submit a KIO patch to use the new icon for the current Root Places Panel item. If we end up not removing it after all, we might as well use the nice new icon! :)

Thanks! I've been thinking about when I should get a developer account.

ngraham added a comment.Nov 9 2018, 10:02 PM

Usually the time is right when someone recommends that you do so! :-)

ngraham added a comment.Nov 9 2018, 10:24 PM

Other VDG folks in chat seem happy as well. Landing it!

Nice work.

Closed by commit R266:e2270613fc25: Add new icons for root (authored by ndavis, committed by ngraham). · Explain WhyNov 9 2018, 10:26 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 16 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 45209

View Options

icons-dark/devices/symbolic/drive-harddisk-root-symbolic.svg

Loading...
View Options

icons/devices/symbolic/drive-harddisk-root-symbolic.svg

Loading...