Details
Details
- Reviewers
apol - Group Reviewers
Plasma - Commits
- R119:19d61b068792: kfontinst: Port to QTemporaryDir
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Unfortunately QTemporaryDir doesn't have filePath() method. But it's a good idea to add it :)
Comment Actions
Ugh, I was convinced it would exist! My apologies for not checking.
For now, can you at least just change from "/" -> QLatin1Char('/')?
Also if you can look into adding the API to Qt that would be great as well.
Other than that, +1
Comment Actions
Add QTemporaryDir::filePath(): https://codereview.qt-project.org/#/c/160366/
"/" are placed before macros that expand to string literals
it's a string literal concatenation, there is no need to change them to QLatin1Char('/')