Unset XKB_DEFAULT_* in tests to make tests better reproducable
ClosedPublic

Authored by graesslin on Nov 7 2018, 3:17 PM.

Details

Summary

On one of my systems XKB_DEFAULT_LAYOUT is set to "de". This makes a few
tests fail, e.g. pointer input and modifier only shortcuts.

The reason is that those tests assume the xkb default layout behavior,
that is how xkb functions without any layout being set. So having the
env variable around influences the layout generation.

To prevent this the environment variables are unset and thus a
reproducable environment is created.

Diff Detail

Repository
R108 KWin
Branch
unset-xkb-default-layout-in-tests
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4676
Build 4694: arc lint + arc unit
graesslin created this revision.Nov 7 2018, 3:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2018, 3:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 7 2018, 3:17 PM
davidedmundson accepted this revision.Nov 7 2018, 3:26 PM
This revision is now accepted and ready to land.Nov 7 2018, 3:26 PM
This revision was automatically updated to reflect the committed changes.