New login screen
ClosedPublic

Authored by davidedmundson on May 24 2016, 10:01 AM.

Details

Summary

Implemented the new login screen as designed by Andreas

Test Plan

As there is a dummydata folder, simply run qmlscene Main.qml to test

Diff Detail

Repository
R120 Plasma Workspace
Branch
login
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson retitled this revision from to New login screen.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 24 2016, 10:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Nice! :)

Finally a user input field.

lookandfeel/contents/loginmanager/Background.qml
36 ↗(On Diff #3961)

My gut feeling always makes me avoid QtGraphicalEffects where possible, ie. a plain Rectangle; especially because the latter doesn't use a ShaderEffectItem (2d renderer)

37 ↗(On Diff #3961)

One line each pls

49 ↗(On Diff #3961)

visible: image.status !== Image.Ready (or at least fix the second condition)

54 ↗(On Diff #3961)

You don't position that thing according to screen geometry

56 ↗(On Diff #3961)

Not needed I think

lookandfeel/contents/loginmanager/BatteryIcon.qml
1 ↗(On Diff #3961)

That can be imported through org.kde.plasma.workspace.components 2.0

lookandfeel/contents/loginmanager/KeyboardButton.qml
23 ↗(On Diff #3961)

Use an Instantiator and use addMenuItem in the onObjectAdded handler (see docs)

lookandfeel/contents/loginmanager/Login.qml
61 ↗(On Diff #3961)

Can we maybe have a question mark dummy face or so here? I think we even had that in the mockups.
The fields look so lost without it

81 ↗(On Diff #3961)

That message never disappears automatically.
If not with a timer, at least when I switch to a different user and/or toggle searching it should.

117 ↗(On Diff #3961)

if (length === 0) return

and then do the other checks separately

lookandfeel/contents/loginmanager/Main.qml
80 ↗(On Diff #3961)

To me it wasn't immediately obvious that this button brought me back to the user overview.

Can this view be defaulted through some settings btw?

90 ↗(On Diff #3961)

I don't like having 5 buttons in the bottom row, can we make that a "Leave" button with a menu like the other buttons?

134 ↗(On Diff #3961)

Can I have a date, too?

lookandfeel/contents/loginmanager/SessionButton.qml
21–22 ↗(On Diff #3961)

Instantiator

lookandfeel/contents/loginmanager/UserDelegate.qml
88 ↗(On Diff #3961)

What an effort for a... circle :D With a gradient

144 ↗(On Diff #3961)

Isn't this Accessible.onPressAction?

lookandfeel/contents/loginmanager/dummydata/userModel.qml
28 ↗(On Diff #3961)

Schweinsteiger ;)

thanks

lookandfeel/contents/loginmanager/Background.qml
36 ↗(On Diff #3961)

I just go with the design.
I could stick in a 1000x1 px png instead?

49 ↗(On Diff #3961)

I wanted to exclude .Loading. You're right I should fix it though

54 ↗(On Diff #3961)

actually I do, it's the gradient that's wrong.

56 ↗(On Diff #3961)

It is as PreserveAspectStretch overflows.
I could make it a conditional on that though. Will be faster and self documenting.

lookandfeel/contents/loginmanager/KeyboardButton.qml
23 ↗(On Diff #3961)

Not sure I can.
That's QtQml 2.2 - which is Qt5.6

I cursed a lot about having to go about this silly way

lookandfeel/contents/loginmanager/UserDelegate.qml
144 ↗(On Diff #3961)

oh wow. ... it used to be this in QtQml1 - and this has been copied all the way from that LightDM code

lookandfeel/contents/loginmanager/dummydata/userModel.qml
28 ↗(On Diff #3961)

...that's even longer!

broulik added inline comments.May 24 2016, 8:37 PM
lookandfeel/contents/loginmanager/Background.qml
36 ↗(On Diff #3961)

Rectangle still allows Gradient with GradientStop, just that the gradient can only be top to bottom which is what we want here anyway.

lookandfeel/contents/loginmanager/KeyboardButton.qml
23 ↗(On Diff #3961)

According to Qt git it was added on 2013-03-20 and I'm pretty sure I've used it a while ago.
In fact, we use it already in plasma-framework in the MonthMenu (I also thought I ported the ModelContextMenu to it put apparently I didn't).

davidedmundson marked 2 inline comments as done.

Fix most of Kai's comments

  • only missing changing the user selection screen, as I dont' know what icon to

use

mart added a subscriber: mart.May 26 2016, 8:12 AM
mart added inline comments.
lookandfeel/contents/loginmanager/Background.qml
36 ↗(On Diff #3961)

are we sure that one is implemented with a software renderer?

lookandfeel/contents/loginmanager/Background.qml
36 ↗(On Diff #3961)

It works with QT_XCB_FORCE_SOFTWARE_OPENGL=1

broulik added inline comments.May 26 2016, 12:04 PM
lookandfeel/contents/loginmanager/Background.qml
36 ↗(On Diff #3961)

The 2D renderer RectangleNode just uses QLinearGradient on a QBrush internally.

Fix most of Kai's comments

  • only missing changing the user selection screen, as I dont' know what icon to use

Which icons do you need? can you tel me the icon names and size. thanks

Fix most of Kai's comments

  • only missing changing the user selection screen, as I dont' know what icon to use

Which icons do you need? can you tel me the icon names and size. thanks

https://community.kde.org/File:RemoteLogin.png

The enormous "?"
and I need it enormous please, with the drop shadow.

If it's only going to be used here, I can include it as an SVG with the login screen.
Don't worry about making it a circle, I can turn re-use the circle + bordering code I have from the main UI.

https://community.kde.org/File:RemoteLogin.png

The enormous "?"
and I need it enormous please, with the drop shadow.

I add the avatars to the breeze-icon repository (/icons/applets/128) you can use them from there. we already have some more avatars which will come asap. the avatar icons use the stylesheed so e.g. the blue background and the white face is from the color plate

does it fit for you, you can use them also in the sddm source code cause I think SDDM can't use the user specific icons.

broulik accepted this revision.Jun 4 2016, 7:26 PM
broulik added a reviewer: broulik.

Just fix those minor nitpicks and then good to go, thanks!

lookandfeel/contents/loginmanager/dummydata/screenModel.qml
14 ↗(On Diff #3961)

Please update that comment to reflect the changes below

24 ↗(On Diff #3961)

x: 1920 ?

30 ↗(On Diff #3961)

Primary is now 1600x900

This revision is now accepted and ready to land.Jun 4 2016, 7:26 PM
davidedmundson edited edge metadata.

Kai's final comments

That last one was a "Fix it, then Ship it!" comment

Go go go before our VDG guys get even more impatient ;)

Go go go before our VDG guys get even more impatient ;)

It's not the VDG it's me Andreas Kainz.

This revision was automatically updated to reflect the committed changes.