Implemented the new login screen as designed by Andreas
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R871:788c0110efcd: New login screen
R120:788c0110efcd: New login screen
As there is a dummydata folder, simply run qmlscene Main.qml to test
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- login
- Lint
No Linters Available - Unit
No Unit Test Coverage
Nice! :)
Finally a user input field.
lookandfeel/contents/loginmanager/Background.qml | ||
---|---|---|
36 ↗ | (On Diff #3961) | My gut feeling always makes me avoid QtGraphicalEffects where possible, ie. a plain Rectangle; especially because the latter doesn't use a ShaderEffectItem (2d renderer) |
37 ↗ | (On Diff #3961) | One line each pls |
49 ↗ | (On Diff #3961) | visible: image.status !== Image.Ready (or at least fix the second condition) |
54 ↗ | (On Diff #3961) | You don't position that thing according to screen geometry |
56 ↗ | (On Diff #3961) | Not needed I think |
lookandfeel/contents/loginmanager/BatteryIcon.qml | ||
1 ↗ | (On Diff #3961) | That can be imported through org.kde.plasma.workspace.components 2.0 |
lookandfeel/contents/loginmanager/KeyboardButton.qml | ||
23 ↗ | (On Diff #3961) | Use an Instantiator and use addMenuItem in the onObjectAdded handler (see docs) |
lookandfeel/contents/loginmanager/Login.qml | ||
61 ↗ | (On Diff #3961) | Can we maybe have a question mark dummy face or so here? I think we even had that in the mockups. |
81 ↗ | (On Diff #3961) | That message never disappears automatically. |
117 ↗ | (On Diff #3961) | if (length === 0) return and then do the other checks separately |
lookandfeel/contents/loginmanager/Main.qml | ||
80 ↗ | (On Diff #3961) | To me it wasn't immediately obvious that this button brought me back to the user overview. Can this view be defaulted through some settings btw? |
90 ↗ | (On Diff #3961) | I don't like having 5 buttons in the bottom row, can we make that a "Leave" button with a menu like the other buttons? |
134 ↗ | (On Diff #3961) | Can I have a date, too? |
lookandfeel/contents/loginmanager/SessionButton.qml | ||
21–22 ↗ | (On Diff #3961) | Instantiator |
lookandfeel/contents/loginmanager/UserDelegate.qml | ||
88 ↗ | (On Diff #3961) | What an effort for a... circle :D With a gradient |
144 ↗ | (On Diff #3961) | Isn't this Accessible.onPressAction? |
lookandfeel/contents/loginmanager/dummydata/userModel.qml | ||
28 ↗ | (On Diff #3961) | Schweinsteiger ;) |
thanks
lookandfeel/contents/loginmanager/Background.qml | ||
---|---|---|
36 ↗ | (On Diff #3961) | I just go with the design. |
49 ↗ | (On Diff #3961) | I wanted to exclude .Loading. You're right I should fix it though |
54 ↗ | (On Diff #3961) | actually I do, it's the gradient that's wrong. |
56 ↗ | (On Diff #3961) | It is as PreserveAspectStretch overflows. |
lookandfeel/contents/loginmanager/KeyboardButton.qml | ||
23 ↗ | (On Diff #3961) | Not sure I can. I cursed a lot about having to go about this silly way |
lookandfeel/contents/loginmanager/UserDelegate.qml | ||
144 ↗ | (On Diff #3961) | oh wow. ... it used to be this in QtQml1 - and this has been copied all the way from that LightDM code |
lookandfeel/contents/loginmanager/dummydata/userModel.qml | ||
28 ↗ | (On Diff #3961) | ...that's even longer! |
lookandfeel/contents/loginmanager/Background.qml | ||
---|---|---|
36 ↗ | (On Diff #3961) | Rectangle still allows Gradient with GradientStop, just that the gradient can only be top to bottom which is what we want here anyway. |
lookandfeel/contents/loginmanager/KeyboardButton.qml | ||
23 ↗ | (On Diff #3961) | According to Qt git it was added on 2013-03-20 and I'm pretty sure I've used it a while ago. |
Fix most of Kai's comments
- only missing changing the user selection screen, as I dont' know what icon to
use
lookandfeel/contents/loginmanager/Background.qml | ||
---|---|---|
36 ↗ | (On Diff #3961) | are we sure that one is implemented with a software renderer? |
lookandfeel/contents/loginmanager/Background.qml | ||
---|---|---|
36 ↗ | (On Diff #3961) | It works with QT_XCB_FORCE_SOFTWARE_OPENGL=1 |
lookandfeel/contents/loginmanager/Background.qml | ||
---|---|---|
36 ↗ | (On Diff #3961) | The 2D renderer RectangleNode just uses QLinearGradient on a QBrush internally. |
https://community.kde.org/File:RemoteLogin.png
The enormous "?"
and I need it enormous please, with the drop shadow.
If it's only going to be used here, I can include it as an SVG with the login screen.
Don't worry about making it a circle, I can turn re-use the circle + bordering code I have from the main UI.
I add the avatars to the breeze-icon repository (/icons/applets/128) you can use them from there. we already have some more avatars which will come asap. the avatar icons use the stylesheed so e.g. the blue background and the white face is from the color plate
does it fit for you, you can use them also in the sddm source code cause I think SDDM can't use the user specific icons.
That last one was a "Fix it, then Ship it!" comment
Go go go before our VDG guys get even more impatient ;)