Differential D16673

[server] Put some text-input v0 exclusive callbacks in v0 class
ClosedPublic
Actions

Authored by romangg on Nov 4 2018, 10:18 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Frameworks
Commits
R127:be0ad76729b6: [server] Put some text-input v0 exclusive callbacks in v0 class
Summary

Requests

  • reset
  • commit_state
  • invoke_action

are used in text-input v0 only and neither in v2 and upcoming
v3 of the unstable text-input protocol.

To increase readability put their callbacks in v0 interface class only.

Test Plan

Compiles

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 4 2018, 10:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 4 2018, 10:18 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
romangg requested review of this revision.Nov 4 2018, 10:18 PM
davidedmundson accepted this revision.Nov 4 2018, 10:20 PM
This revision is now accepted and ready to land.Nov 4 2018, 10:20 PM
Closed by commit R127:be0ad76729b6: [server] Put some text-input v0 exclusive callbacks in v0 class (authored by romangg). · Explain WhyNov 4 2018, 10:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44872

View Options

src/server/textinput_interface.cpp

Loading...
View Options

src/server/textinput_interface_p.h

Loading...
View Options

src/server/textinput_interface_v0.cpp

Loading...