| apol |
| KNewStuff |
Previously, KNSCore only signalled errors using string messages, which were useful for fault finding, but not useful when attempting to handle errors during general operation. This patch adds a signal which is fired at the same time as some error messages, and which provides error condition information which is useful in a programmatical fashion.
This patch would allow https://bugs.kde.org/show_bug.cgi?id=395937 to be fixed in a non-hackish fashion.
| Lint Skipped |
| Unit Tests Skipped |
| src/core/engine.h | ||
|---|---|---|
| 430 ↗ | (On Diff #44855) | I would include the error message here and deprecate signalError. Otherwise it's going to be a mess matching both signals. |
| src/core/engine.h | ||
|---|---|---|
| 430 ↗ | (On Diff #44855) | Quite a good point, yes - i've done a bit of jiggling around, new patch incoming |
Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want.
Good idea, yes, i'll get that whipped together and submitted with reference to this one :)