Differential D16629

Allow hide/show unfocused items in the function list
ClosedPublic
Actions

Authored by yurchor on Nov 3 2018, 8:26 AM.

Details

Reviewers
tcanabrava
Group Reviewers
KDE Edu
Commits
R334:17c6978f38b0: Allow hide/show unfocused items in the function list
Summary

Adopted patch by Mario Bensi

BUG: 302691

Test Plan
  1. Create two plots (e.g. x^2 and x^3).
  2. Untick the first created plot in the function list. The plot should disappear.
  3. Untick the second plot. The plot should disappear.
  4. Tick the first plot again. The plot should appear again.

Diff Detail

Repository
R334 KmPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Nov 3 2018, 8:26 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 3 2018, 8:26 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Nov 3 2018, 8:26 AM
tcanabrava accepted this revision.Nov 5 2018, 8:40 AM
tcanabrava added a subscriber: tcanabrava.

While this seems correct the code feels like it should be part of a model. I'm +1 this but can you add a TODO: to create a proper model later?

This revision is now accepted and ready to land.Nov 5 2018, 8:40 AM
yurchor added a comment.Nov 5 2018, 1:50 PM
In D16629#354332, @tcanabrava wrote:

While this seems correct the code feels like it should be part of a model. I'm +1 this but can you add a TODO: to create a proper model later?

Sure. Thanks for your review.

Closed by commit R334:17c6978f38b0: Allow hide/show unfocused items in the function list (authored by yurchor). · Explain WhyNov 5 2018, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkmplot/functioneditor.h (4 lines)
Mkmplot/functioneditor.cpp (19 lines)

Diff 44909

View Options

kmplot/functioneditor.h

Loading...
View Options

kmplot/functioneditor.cpp

Loading...