Differential D16628

[ksmserver] Remove blocking call introspecting KDED
ClosedPublic
Actions

Authored by davidedmundson on Nov 3 2018, 6:41 AM.

Details

Reviewers
romangg
Group Reviewers
Plasma
Commits
R120:c8ed48fc1a2a: [ksmserver] Remove blocking call introspecting KDED
Summary

We don't need to introspect at runtime as KDED installs the interface
XML file.

Oddly KDED's package is called KDED not KF5KDED, hence the separate
find_package, I don't know if that's a bug in frameworks or not.

Test Plan

Compiles

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4501
Build 4519: arc lint + arc unit
davidedmundson created this revision.Nov 3 2018, 6:41 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 3 2018, 6:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 3 2018, 6:41 AM
romangg accepted this revision.Nov 4 2018, 10:09 AM
This revision is now accepted and ready to land.Nov 4 2018, 10:09 AM
Closed by commit R120:c8ed48fc1a2a: [ksmserver] Remove blocking call introspecting KDED (authored by davidedmundson). · Explain WhyNov 8 2018, 1:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Mksmserver/CMakeLists.txt (1 line)
Mksmserver/startup.cpp (9 lines)

Diff 44752

View Options

CMakeLists.txt

Loading...
View Options

ksmserver/CMakeLists.txt

Loading...
View Options

ksmserver/startup.cpp

Loading...