Differential D16613

Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16
ClosedPublic
Actions

Authored by eduisters on Nov 2 2018, 4:45 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:4eecf187c325: Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16
Summary

Manifest.permission.READ_EXTERNAL_STORAGE was added in API 16 so older API's do not
have to request this permission

Test Plan

Install on API < 16 device or emulator
Pair and browse device using dolphin

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Nov 2 2018, 4:45 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 2 2018, 4:45 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Nov 2 2018, 4:45 PM
eduisters added a comment.Nov 2 2018, 4:46 PM

Makes my old phone usable again

nicolasfella added a subscriber: nicolasfella.Nov 6 2018, 6:55 PM
nicolasfella added inline comments.
src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java
143

super.getRequiredPermissions() returns an empty array, no need to call it

eduisters updated this revision to Diff 45005.Nov 7 2018, 8:11 AM
  • Don't call super.getRequiredPermissions() just return an empty String array
eduisters marked an inline comment as done.Nov 7 2018, 8:12 AM
albertvaka accepted this revision.Nov 7 2018, 3:03 PM
This revision is now accepted and ready to land.Nov 7 2018, 3:03 PM
Closed by commit R225:4eecf187c325: Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16 (authored by eduisters, committed by albertvaka). · Explain WhyNov 7 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45037

View Options

src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java

Loading...