Differential D16598

enable animations for standalone created buttons
ClosedPublic
Actions

Authored by mvourlakos on Nov 1 2018, 7:50 PM.

Details

Reviewers
hpereiradacosta
zzag
Group Reviewers
Plasma
Commits
R113:f88caf298dbe: enable animations for standalone created buttons
Summary

--as mentioned at T9899 we are not calling the correct
creator when buttons are created in Standalone mode and
as such animations are disabled when OxygenButton is created
from plasma applets. This patch fixes this and restores
the Standalone behavior mode in order to be identical
with the default one.

Test Plan

-check that window title bars still work
-check that when buttons are used in a plasma applet
they are animated

Diff Detail

Repository
R113 Oxygen Theme
Branch
fixCreator
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4453
Build 4471: arc lint + arc unit
mvourlakos created this revision.Nov 1 2018, 7:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 1 2018, 7:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Nov 1 2018, 7:50 PM
zzag accepted this revision.Nov 1 2018, 8:20 PM
This revision is now accepted and ready to land.Nov 1 2018, 8:20 PM
Closed by commit R113:f88caf298dbe: enable animations for standalone created buttons (authored by mvourlakos). · Explain WhyNov 1 2018, 8:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkdecoration/oxygenbutton.cpp (11 lines)

Diff 44667

View Options

kdecoration/oxygenbutton.cpp

Loading...