Not every data we store in the package is a tar file.

Authored by knauss on Nov 1 2018, 10:20 AM.



Make it possible to change the suffix so we can change the suffix for
the abibuilder. Otherwise humans and f.ex. vi/vim get confused by the filesuffix.

Diff Detail

R857 CI System Tooling
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Nov 1 2018, 10:20 AM
knauss created this revision.
knauss edited tasks, added T3689: Add abi compliance checker to CI; removed Restricted Maniphest Task.Nov 1 2018, 10:21 AM

Aside from the above comment this looks fine to me!


Could you please align the = with the other three ones there?

Also, in terms of variable name, could we have something that makes it clear what this suffix is for?
(something like self.resourceSuffix perhaps?)

knauss updated this revision to Diff 44625.Nov 1 2018, 11:32 AM
knauss marked an inline comment as done.

Fixed Ben's issues.

knauss added inline comments.Nov 1 2018, 11:34 AM

IMO don't like the align at =, as this make the diff bigger than necessary.

bcooksley accepted this revision.Nov 2 2018, 5:41 AM

Thanks for those changes, this looks good to me - i'll land this shortly.

This revision is now accepted and ready to land.Nov 2 2018, 5:41 AM
This revision was automatically updated to reflect the committed changes.
knauss added inline comments.Nov 2 2018, 8:52 PM

sorry here I forgotten to update suffix -> contentsSuffix