Differential D16581

Not every data we store in the package is a tar file.
ClosedPublic
Actions

Authored by knauss on Nov 1 2018, 10:20 AM.

Details

Reviewers

bcooksley

Maniphest Tasks

T3689: Add abi compliance checker to CI

Commits

R857:5114cf7e6ff2: Allow for the appropriate file extension to use on files to be specified when…

Summary

Make it possible to change the suffix so we can change the suffix for
the abibuilder. Otherwise humans and f.ex. vi/vim get confused by the filesuffix.

Diff Detail

Repository

R857 CI System Tooling

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4419
Build 4437: arc lint + arc unit

knauss requested review of this revision.Nov 1 2018, 10:20 AM

knauss created this revision.

Harbormaster completed remote builds in B4419: Diff 44614.Nov 1 2018, 10:20 AM

knauss edited tasks, added T3689: Add abi compliance checker to CI; removed Restricted Maniphest Task.Nov 1 2018, 10:21 AM

Aside from the above comment this looks fine to me!

helpers/helperslib/Packages.py
23	Could you please align the = with the other three ones there? Also, in terms of variable name, could we have something that makes it clear what this suffix is for? (something like self.resourceSuffix perhaps?)

Fixed Ben's issues.

Harbormaster completed remote builds in B4429: Diff 44625.Nov 1 2018, 11:32 AM

knauss added inline comments.Nov 1 2018, 11:34 AM

helpers/helperslib/Packages.py
23	IMO don't like the align at =, as this make the diff bigger than necessary.

knauss mentioned this in T3689: Add abi compliance checker to CI.Nov 1 2018, 2:22 PM

knauss mentioned this in D16589: Add script to check the ABI of the created libraries..

Thanks for those changes, this looks good to me - i'll land this shortly.

This revision is now accepted and ready to land.Nov 2 2018, 5:41 AM

Closed by commit R857:5114cf7e6ff2: Allow for the appropriate file extension to use on files to be specified when… (authored by bcooksley). · Explain WhyNov 2 2018, 7:11 PM

This revision was automatically updated to reflect the committed changes.

knauss added inline comments.Nov 2 2018, 8:52 PM

helpers/create-abi-dump.py
276	sorry here I forgotten to update suffix -> contentsSuffix

bcooksley mentioned this in R857:cdfa0d74bcd0: Update variable name per comment from Sandro..Nov 3 2018, 3:18 AM

This has now been fixed in cdfa0d74bcd096acb51f8c015496d60977439c83

Revision Contents
Changeset List

			Path	Packages
M			helpers/create-abi-dump.py (2 lines)
M			helpers/helperslib/Packages.py (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44614	64b0cc9		Nov 1 2018, 10:20 AM	★	★
Diff 2	44625	64b0cc9	Fixed Ben's issues.	Nov 1 2018, 11:32 AM	★	★
Diff 3	44716	64b0cc9	R857:5114cf7e6ff2bcccddb5bb08c3074e41a3636b34	Nov 2 2018, 6:36 PM	★	★

Not every data we store in the package is a tar file.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 44614

helpers/create-abi-dump.py

helpers/helperslib/Packages.py

Not every data we store in the package is a tar file.
ClosedPublic
Actions

Revision Contents
Changeset List