Details

Reviewers

Commits

R286:0375eee8a128: move supported mimetypes to static string list

Summary

Do not create the list of supported mime types on demand
and use a static stringlist instead.
Order alphabetically where required

Diff Detail

Repository

R286 KFileMetaData

Branch

mimetype_lists

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4448
Build 4466: arc lint + arc unit

astippich created this revision.Oct 31 2018, 8:50 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 31 2018, 8:50 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Oct 31 2018, 8:50 PM

Harbormaster completed remote builds in B4382: Diff 44572.Oct 31 2018, 8:50 PM

astippich mentioned this in D16489: [KFileMetaData] Add extractor for generic XML and SVG.Oct 31 2018, 9:20 PM

bruns added inline comments.Nov 1 2018, 2:09 AM

src/extractors/epubextractor.cpp
36–37	Opening braces should go on the same line for everything but functions ...
38–42	you can put the static mimetypes variable here in the anonymous namespace

coding style fixes
use anonymous namespace

Harbormaster completed remote builds in B4417: Diff 44612.Nov 1 2018, 10:12 AM

adjust taglibwriter

Harbormaster completed remote builds in B4418: Diff 44613.Nov 1 2018, 10:14 AM

bruns added inline comments.Nov 1 2018, 1:28 PM

src/extractors/epubextractor.cpp
44 ↗	(On Diff #44613)	The idea behind using anonymous namespaces is to neither "pollute" the class namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, see `fetchMetadata`.

astippich added inline comments.Nov 1 2018, 4:16 PM

src/extractors/epubextractor.cpp
44 ↗	(On Diff #44613)	All the stringlists are currently implemented as a private static member of the class... would you like to change that to a local static variable?

bruns added inline comments.Nov 1 2018, 6:21 PM

src/extractors/epubextractor.cpp
44 ↗	(On Diff #44613)	I consider this cleaner, yes. We don't expose static helper functions, either.

use local static variable

Harbormaster completed remote builds in B4448: Diff 44661.Nov 1 2018, 7:04 PM

bruns accepted this revision.Nov 1 2018, 8:59 PM

bruns added inline comments.

src/extractors/taglibextractor.cpp
71	w < x

This revision is now accepted and ready to land.Nov 1 2018, 8:59 PM

Closed by commit R286:0375eee8a128: move supported mimetypes to static string list (authored by astippich). · Explain WhyNov 4 2018, 9:45 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/extractors/epubextractor.h (3 lines)
M			src/extractors/epubextractor.cpp (16 lines)
M			src/extractors/exiv2extractor.h (1 line)
M			src/extractors/exiv2extractor.cpp (48 lines)
M			src/extractors/ffmpegextractor.h (3 lines)
M			src/extractors/ffmpegextractor.cpp (26 lines)
M			src/extractors/odfextractor.h (1 line)
M			src/extractors/odfextractor.cpp (13 lines)
M			src/extractors/office2007extractor.h (1 line)
M			src/extractors/office2007extractor.cpp (12 lines)
M			src/extractors/plaintextextractor.h (3 lines)
M			src/extractors/plaintextextractor.cpp (6 lines)
M			src/extractors/poextractor.h (1 line)
M			src/extractors/poextractor.cpp (6 lines)
M			src/extractors/popplerextractor.h (1 line)
M			src/extractors/popplerextractor.cpp (10 lines)
M			src/extractors/taglibextractor.h (1 line)
M			src/extractors/taglibextractor.cpp (36 lines)
M			src/writers/taglibwriter.h (3 lines)
M			src/writers/taglibwriter.cpp (28 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44572	4c40878		Oct 31 2018, 8:50 PM	★	★
Diff 2	44612	4c40878	- coding style fixes	Nov 1 2018, 10:12 AM	★	★
Diff 3	44613	4c40878	- adjust taglibwriter	Nov 1 2018, 10:14 AM	★	★
Diff 4	44661	1b24269	- use local static variable	Nov 1 2018, 7:04 PM	★	★
Diff 5	44825	e04ef70	R286:0375eee8a128bd84e0927538ea915b0deb382eff	Nov 4 2018, 9:45 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
9c5017425e16	06cd852ab7c8	996597fc168c	Alexander Stippich	cleanup	Nov 1 2018, 7:00 PM
996597fc168c	5790fe0f2bd2	bfed6aa65c59	Alexander Stippich	use a local static variable	Nov 1 2018, 6:47 PM
bfed6aa65c59	97ca0a90a04d	a62e2357382b	Alexander Stippich	adjust taglibwriter	Nov 1 2018, 10:14 AM
a62e2357382b	82b8bed52f69	b091777377a2	Alexander Stippich	use anonymous namespace	Nov 1 2018, 10:12 AM
b091777377a2	ff166e0db68a	bbb344f24e97	Alexander Stippich	coding style fixes	Nov 1 2018, 9:56 AM
bbb344f24e97	98a6cce2d65c	1b242697d27d	Alexander Stippich	move supported mimetypes to static string list (Show More…)	Oct 28 2018, 6:41 PM

move supported mimetypes to static string list
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 44661

src/extractors/epubextractor.h

src/extractors/epubextractor.cpp

src/extractors/exiv2extractor.h

src/extractors/exiv2extractor.cpp

src/extractors/ffmpegextractor.h

src/extractors/ffmpegextractor.cpp

src/extractors/odfextractor.h

src/extractors/odfextractor.cpp

src/extractors/office2007extractor.h

src/extractors/office2007extractor.cpp

src/extractors/plaintextextractor.h

src/extractors/plaintextextractor.cpp

src/extractors/poextractor.h

src/extractors/poextractor.cpp

src/extractors/popplerextractor.h

src/extractors/popplerextractor.cpp

src/extractors/taglibextractor.h

src/extractors/taglibextractor.cpp

src/writers/taglibwriter.h

src/writers/taglibwriter.cpp

move supported mimetypes to static string listClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 44661

src/extractors/epubextractor.h

src/extractors/epubextractor.cpp

src/extractors/exiv2extractor.h

src/extractors/exiv2extractor.cpp

src/extractors/ffmpegextractor.h

src/extractors/ffmpegextractor.cpp

src/extractors/odfextractor.h

src/extractors/odfextractor.cpp

src/extractors/office2007extractor.h

src/extractors/office2007extractor.cpp

src/extractors/plaintextextractor.h

src/extractors/plaintextextractor.cpp

src/extractors/poextractor.h

src/extractors/poextractor.cpp

src/extractors/popplerextractor.h

src/extractors/popplerextractor.cpp

src/extractors/taglibextractor.h

src/extractors/taglibextractor.cpp

src/writers/taglibwriter.h

src/writers/taglibwriter.cpp

move supported mimetypes to static string list
ClosedPublic
Actions

Revision Contents
Changeset List