Do not create the list of supported mime types on demand
and use a static stringlist instead.
Order alphabetically where required
Details
Details
- Reviewers
bruns - Commits
- R286:0375eee8a128: move supported mimetypes to static string list
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- mimetype_lists
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4418 Build 4436: arc lint + arc unit
| src/extractors/epubextractor.cpp | ||
|---|---|---|
| 44 | The idea behind using anonymous namespaces is to neither "pollute" the class namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, see fetchMetadata. | |
| src/extractors/epubextractor.cpp | ||
|---|---|---|
| 44 | All the stringlists are currently implemented as a private static member of the class... would you like to change that to a local static variable? | |
| src/extractors/epubextractor.cpp | ||
|---|---|---|
| 44 | I consider this cleaner, yes. | |
| src/extractors/taglibextractor.cpp | ||
|---|---|---|
| 71 ↗ | (On Diff #44612) | w < x |