Connect slots explicitly instead of using auto-connections
ClosedPublic

Authored by volkov on Oct 31 2018, 2:51 PM.

Details

Summary

Auto-connections is bad practice cause object renames break code
and it can't be detected at compile time.

Diff Detail

Repository
R121 Policykit (Polkit) KDE Agent
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4368
Build 4386: arc lint + arc unit
volkov created this revision.Oct 31 2018, 2:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 31 2018, 2:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
volkov requested review of this revision.Oct 31 2018, 2:51 PM
volkov updated this revision to Diff 44551.Oct 31 2018, 2:54 PM

rename slot

davidedmundson accepted this revision.Oct 31 2018, 3:14 PM
This revision is now accepted and ready to land.Oct 31 2018, 3:14 PM
volkov closed this revision.Oct 31 2018, 3:35 PM