Differential D16546

Set StartupWMClass in desktop file
ClosedPublic
Actions

Authored by hallas on Oct 31 2018, 2:50 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:1506ecdfd0f9: Add StartupWMClass to .desktop file
R319:930594bf9446: Add StartupWMClass to .desktop file
Summary

The org.kde.konsole.desktop file is missing a StartupWMClass setting.

BUG: 372441

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hallas created this revision.Oct 31 2018, 2:50 PM
Restricted Application added a project: Konsole. · View Herald TranscriptOct 31 2018, 2:50 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
hallas requested review of this revision.Oct 31 2018, 2:50 PM
hindenburg added a comment.Nov 2 2018, 1:42 AM

It doesn't appear it is in the correct location - I think it needs to be up near the top

% desktop-file-validate desktop/org.kde.konsole.desktop
desktop/org.kde.konsole.desktop: error: file contains key "StartupWMClass" in group "Desktop Action NewTab", but keys extending the format should start with "X-"

hindenburg added a comment.Nov 10 2018, 1:32 AM
18.12 is split off - can you update this patch?
This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2018, 3:29 PM
Closed by commit R319:1506ecdfd0f9: Add StartupWMClass to .desktop file (authored by hallas, committed by hindenburg).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
hallas added a comment.Nov 12 2018, 8:07 AM


In D16546#357174, @hindenburg wrote:


18.12 is split off - can you update this patch?





Sorry, I was offline for a couple of days :) Good to see that you updated the patch and submitted it.
Revision Contents
Changeset List
PathPackages
Mdesktop/org.kde.konsole.desktop (1 line)
Diff 45297
View Options
desktop/org.kde.konsole.desktop
Loading...