Differential D16536

[fontinst KCM] Slightly modernize layout
ClosedPublic
Actions

Authored by ngraham on Oct 30 2018, 11:14 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Maniphest Tasks
T9954: GHNS buttons should be in the bottom-right corner of the KCM window
Commits
R119:8a74e73228ef: [fontinst KCM] Slightly modernize layout
Summary

The Font Install KCM has a very dated layout. Thisd patch addresses some (but not all) of the aesthetic and usability deficiencies by doing the following:

  • Eliminate the tools menu and relocate its two items elsewhere
  • Move the GHNS button to the bottom-right corner, like every other KCM
  • Put the Scan for Duplicate Fonts... action on the toolbar
  • Change Add... into Install from File... to match the style of other KCMs
Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
kcm-fontint-minor-modernization (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4355
Build 4373: arc lint + arc unit
ngraham created this revision.Oct 30 2018, 11:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 30 2018, 11:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 30 2018, 11:14 PM
ngraham edited the test plan for this revision. (Show Details)Oct 30 2018, 11:15 PM
davidedmundson accepted this revision.Nov 5 2018, 11:02 PM
This revision is now accepted and ready to land.Nov 5 2018, 11:02 PM
Closed by commit R119:8a74e73228ef: [fontinst KCM] Slightly modernize layout (authored by ngraham). · Explain WhyNov 5 2018, 11:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44523

View Options

kcms/kfontinst/kcmfontinst/KCmFontInst.h

Loading...
View Options

kcms/kfontinst/kcmfontinst/KCmFontInst.cpp

Loading...