[effects/desktopgrid] Don't display the close button from Present Windows
ClosedPublic

Authored by zzag on Oct 29 2018, 1:17 PM.

Details

Summary

If you activate the Present Windows effect and then the Desktop Grid,
you'll be able to see the close button from PW. The reason for that is
PW doesn't destroy the close button and DG doesn't filter it out.

This patch addesses this problem by syncing DesktopGridEffect::isRelevantWithPresentWindows
with PresentWindowsEffect::isSelectableWindow.

On X11, the close button is filtered by the isSpecialWindow check. On
Wayland, the close button is filtered by the acceptsFocus check.

The proposed solution is kinda hack-ish, but on the other hand, we have
to keep those two methods in sync anyway.

In addition to the close button, notifications won't be displayed too.

BUG: 364710
FIXED-IN: 5.14.3

Test Plan
  • Activate the Present Windows effect;
  • Activate the Desktop Grid effect;
  • (the close button is no longer visible)

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Oct 29 2018, 1:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 29 2018, 1:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 29 2018, 1:17 PM
graesslin accepted this revision.Oct 30 2018, 7:19 PM
This revision is now accepted and ready to land.Oct 30 2018, 7:19 PM
This revision was automatically updated to reflect the committed changes.