Diffusion KWin 558b86e9f6c0

[effects/desktopgrid] Don't display the close button from Present Windows

Authored by zzag on Oct 29 2018, 12:29 PM.

Description

[effects/desktopgrid] Don't display the close button from Present Windows

Summary:
If you activate the Present Windows effect and then the Desktop Grid,
you'll be able to see the close button from PW. The reason for that is
PW doesn't destroy the close button and DG doesn't filter it out.

This patch addesses this problem by syncing DesktopGridEffect::isRelevantWithPresentWindows
with PresentWindowsEffect::isSelectableWindow.

On X11, the close button is filtered by the isSpecialWindow check. On
Wayland, the close button is filtered by the acceptsFocus check.

The proposed solution is kinda hack-ish, but on the other hand, we have
to keep those two methods in sync anyway.

In addition to the close button, notifications won't be displayed too.

BUG: 364710
FIXED-IN: 5.14.3

Test Plan:

  • Activate the Present Windows effect;
  • Activate the Desktop Grid effect;
  • (the close button is no longer visible)

Reviewers: KWin, graesslin

Reviewed By: KWin, graesslin

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D16513

Details

Committed
zzagOct 30 2018, 8:39 PM
Reviewer
KWin
Differential Revision
D16513: [effects/desktopgrid] Don't display the close button from Present Windows
Parents
R108:8fa1537d6ffb: Merge branch 'Plasma/5.12' into Plasma/5.14
Branches
Unknown
Tags
Unknown