Differential D16511

Update session icon on notification bell
ClosedPublic
Actions

Authored by EspadaV8 on Oct 29 2018, 10:45 AM.

Details

Reviewers
konsole-devel
hindenburg
ngraham
Group Reviewers
Konsole
Commits
R319:674243f126bb: Update session icon on notification bell
Summary

Change the icon of the session when a bel is triggered as a visually alert

BUG: 399140
FIXED-IN: 18.12

Test Plan
  1. Start Konsole and create 2 sessions (tabs) from the same profile (for example, the default profile)
  2. In one tab run sleep 3; tput bel
  3. Switch to the other tab and wait 3 seconds

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
EspadaV8 requested review of this revision.Oct 29 2018, 10:45 AM
EspadaV8 created this revision.
ngraham accepted this revision.Nov 1 2018, 2:13 PM
ngraham added a subscriber: ngraham.

Brilliant, I love it! Works great and the code looks sane to me. Let's wait for @hindenburg's final review. Thanks for the contribution!

This revision is now accepted and ready to land.Nov 1 2018, 2:13 PM
hindenburg added a comment.Nov 1 2018, 3:06 PM

looks fine - thanks - if you are using arc please set your name and email when you upload the patch - can you provide your name and email address please?

hindenburg edited the summary of this revision. (Show Details)Nov 1 2018, 3:07 PM
hindenburg edited the test plan for this revision. (Show Details)
EspadaV8 added a comment.Nov 1 2018, 8:28 PM

I did not use arc, but I shall for the next one.

Andrew Smith
espadav8@gmail.com

Thanks

Closed by commit R319:674243f126bb: Update session icon on notification bell (authored by EspadaV8, committed by hindenburg). · Explain WhyNov 1 2018, 10:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/SessionController.cpp (5 lines)

Diff 44676

View Options

src/SessionController.cpp

Loading...