Differential D16446

[KIconLoader] Replace heap-allocated QImageReader with stack-allocated one
ClosedPublic
Actions

Authored by bruns on Oct 26 2018, 11:24 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R302:34994ba9890d: [KIconLoader] Replace heap-allocated QImageReader with stack-allocated one
R302:975fb3ed8a7e: Revert "Use the right scope for variable"
Summary

Minor optimization, saves one new/delete pair per non-cached icon.

Test Plan

make
no functional change

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 26 2018, 11:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 26 2018, 11:24 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 26 2018, 11:24 PM
apol accepted this revision.Oct 26 2018, 11:33 PM
This revision is now accepted and ready to land.Oct 26 2018, 11:33 PM
Closed by commit R302:34994ba9890d: [KIconLoader] Replace heap-allocated QImageReader with stack-allocated one (authored by bruns). · Explain WhyOct 26 2018, 11:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kiconloader.cpp (12 lines)

Diff 44276

View Options

src/kiconloader.cpp

Loading...