Differential D16431

Guard data source being deleted before processing dataoffer receive event
ClosedPublic
Actions

Authored by davidedmundson on Oct 25 2018, 11:51 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R127:8fe4a2756cdb: Guard data source being deleted before processing dataoffer receive event
Summary

A data source can disappear at any moment, it's plausible a client could
have requested data whilst the client was alive and we are processing it
afterwards.

The accept and finish callback guard against the source being deleted,
but recieve did not.

BUG: 400311

Test Plan

Could still copy/paste as before

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 25 2018, 11:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Oct 25 2018, 11:51 PM
romangg accepted this revision.Oct 29 2018, 9:58 AM
This revision is now accepted and ready to land.Oct 29 2018, 9:58 AM
Closed by commit R127:8fe4a2756cdb: Guard data source being deleted before processing dataoffer receive event (authored by davidedmundson). · Explain WhyOct 29 2018, 10:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/server/dataoffer_interface.cpp (6 lines)

Diff 44422

View Options

src/server/dataoffer_interface.cpp

Loading...