Differential D16422

Do not reset equalizer on clicking cancel if equalizer toggle is off.
ClosedPublic
Actions

Authored by elbinp on Oct 25 2018, 3:25 AM.

Details

Reviewers
heikobecker
Group Reviewers
Amarok
Commits
R181:1049bef08812: Do not reset equalizer on clicking cancel if equalizer toggle is off.
Summary

Only restore original settings if the equalizer was originally enabled or if the equalizer is currently enabled. This prevents a reset of the equalizer when cancel button is clicked with equalizer toggle off.

Diff Detail

Repository
R181 Amarok
Lint
Lint Skipped
Unit
Unit Tests Skipped
elbinp created this revision.Oct 25 2018, 3:25 AM
Restricted Application removed a project: Amarok. · View Herald TranscriptOct 25 2018, 3:25 AM
Restricted Application added a subscriber: amarok-devel. · View Herald Transcript
elbinp requested review of this revision.Oct 25 2018, 3:25 AM
heikobecker accepted this revision.Oct 28 2018, 10:56 PM
heikobecker added a subscriber: heikobecker.

Thanks!

This revision is now accepted and ready to land.Oct 28 2018, 10:56 PM
elbinp added a comment.Oct 29 2018, 12:08 AM

Can you push these changes or let me know how I can push these changes to upstream?

Thanks.

heikobecker added a comment.Oct 29 2018, 7:42 AM

I can push it for you, but I need your email address.

elbinp added a comment.Oct 29 2018, 8:02 AM

Elbin dot p at gmail dot com

Closed by commit R181:1049bef08812: Do not reset equalizer on clicking cancel if equalizer toggle is off. (authored by elbinp, committed by heikobecker). · Explain WhyOct 29 2018, 8:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dialogs/EqualizerDialog.cpp (16 lines)

Diff 44196

View Options

src/dialogs/EqualizerDialog.cpp

Loading...