Do not reset equalizer on clicking cancel if equalizer toggle is off.
ClosedPublic

Authored by elbinp on Oct 25 2018, 3:25 AM.

Details

Summary

Only restore original settings if the equalizer was originally enabled or if the equalizer is currently enabled. This prevents a reset of the equalizer when cancel button is clicked with equalizer toggle off.

Diff Detail

Repository
R181 Amarok
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elbinp created this revision.Oct 25 2018, 3:25 AM
Restricted Application removed a project: Amarok. · View Herald TranscriptOct 25 2018, 3:25 AM
Restricted Application added a subscriber: amarok-devel. · View Herald Transcript
elbinp requested review of this revision.Oct 25 2018, 3:25 AM
heikobecker accepted this revision.Oct 28 2018, 10:56 PM
heikobecker added a subscriber: heikobecker.

Thanks!

This revision is now accepted and ready to land.Oct 28 2018, 10:56 PM

Can you push these changes or let me know how I can push these changes to upstream?

Thanks.

I can push it for you, but I need your email address.

Elbin dot p at gmail dot com

This revision was automatically updated to reflect the committed changes.