Differential D16376

[tabswitcher] Fix beginRemoveRows call
ClosedPublic
Actions

Authored by davidedmundson on Oct 22 2018, 4:05 PM.

Details

Reviewers
dhaumann
Group Reviewers
Kate
Commits
R40:23ac7ed7ea6f: [tabswitcher] Fix beginRemoveRows call
Summary

To remove one row first and last should be the same index.

This hit an assert on newer Qt.

Test Plan

I hit this booting up with no args with kate
restoring to split views each with one document.

From the calling code it seems to be trying to just remove one row.

It now starts. Hitting control+n, control_w does add/remove tabs respectively

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4129
Build 4147: arc lint + arc unit
davidedmundson created this revision.Oct 22 2018, 4:05 PM
Restricted Application added a project: Kate. · View Herald TranscriptOct 22 2018, 4:05 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
davidedmundson requested review of this revision.Oct 22 2018, 4:05 PM
dhaumann accepted this revision.Oct 22 2018, 8:33 PM
dhaumann added a subscriber: dhaumann.

Thanks!

This revision is now accepted and ready to land.Oct 22 2018, 8:33 PM
Closed by commit R40:23ac7ed7ea6f: [tabswitcher] Fix beginRemoveRows call (authored by davidedmundson). · Explain WhyOct 23 2018, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44078

View Options

addons/tabswitcher/tabswitcherfilesmodel.cpp

Loading...