Differential D1635

[OSD] Make volume OSD thresholds consistent with Volume Applet
ClosedPublic
Actions

Authored by broulik on May 18 2016, 8:50 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:ad36c6dba6a7: [OSD] Make volume OSD thresholds consistent with Volume Applet
R120:ad36c6dba6a7: [OSD] Make volume OSD thresholds consistent with Volume Applet
Summary

The volume applet would switch at 26% from low to medium whereas the OSD did that at 25%.
Also turn the logic around so it's identical to what plasma-pa does.

Test Plan

As noticed by Andreas.

I wonder why we use 0, 25, 75, 100 though and not 0, 33, 66, 100

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 3868.May 18 2016, 8:50 PM
broulik retitled this revision from to [OSD] Make volume OSD thresholds consistent with Volume Applet.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 18 2016, 8:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca added a subscriber: drosca.May 18 2016, 9:04 PM

I wonder why we use 0, 25, 75, 100 though and not 0, 33, 66, 100

Not sure, but the medium threshold looks fine to me because most of the times you keep your volume in lower levels (because >50% is too loud), so it makes sense to show "medium" icon (one bar filled) sooner - over 25% and not 33%.

Can you please also change it in microphone volume OSD I just committed? Thanks

mart accepted this revision.May 19 2016, 2:28 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.May 19 2016, 2:28 PM
broulik updated this revision to Diff 3885.May 19 2016, 2:35 PM
broulik edited edge metadata.

Also adjust microphone OSD

Closed by commit R120:ad36c6dba6a7: [OSD] Make volume OSD thresholds consistent with Volume Applet (authored by broulik). · Explain WhyJun 6 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/osd.cpp (28 lines)

Diff 4249

View Options

shell/osd.cpp

Loading...