Differential D16316

[Kicker] Rename id column to itemColumn
ClosedPublic
Actions

Authored by broulik on Oct 19 2018, 1:00 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:004d838c2718: [Kicker] Rename id column to itemColumn
Summary

In Qt 5.12 new magic column and row properties appeared in the delegate's scope, similar to the index and model (modelData) one.
This causes column to access that (being always the number zero for this list model) and as such the delegate not having a width and turning invisible.

Test Plan

So much for Qt versioning... quite a horrible behavior change as I typically also just call my Column column... let's work around this in 5.14 (or even 5.12 since it's quite trivial change) here and escalate to Qt then...

  • All apps and krunner in kickerdash work again

Qt Bug Report: https://bugreports.qt.io/browse/QTBUG-70031

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 19 2018, 1:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 19 2018, 1:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 19 2018, 1:00 PM
broulik edited the test plan for this revision. (Show Details)Oct 19 2018, 1:17 PM
hein accepted this revision.Oct 19 2018, 1:51 PM
This revision is now accepted and ready to land.Oct 19 2018, 1:51 PM
Closed by commit R119:004d838c2718: [Kicker] Rename id column to itemColumn (authored by broulik). · Explain WhyOct 22 2018, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44067

View Options

applets/kicker/package/contents/ui/ItemMultiGridView.qml

Loading...