Add earth shadow + lunar eclipse finder
ClosedPublic

Authored by vboettcher on Oct 18 2018, 5:32 PM.

Details

Summary

I've added functionality to calculate and draw the earths shadow disk in moon (or theoretically any) distance.

There is a new eclipse tool in the astrocalc which can find lunar eclipses quite fast. I've overhauled and modularized the original ksconjunct code for that.

The eclipsetool comes with an API that can be extended for other eclipse types.

This is WiP as the eclipse details functionality for generating nice printouts is still missing.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
vboettcher created this revision.Oct 18 2018, 5:32 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 18 2018, 5:32 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
vboettcher requested review of this revision.Oct 18 2018, 5:32 PM
mutlaqja requested changes to this revision.Oct 18 2018, 6:32 PM

Beautiful work Valentine! Can you please rebase and fix the small CMake issue?

CMakeLists.txt
8 ↗(On Diff #43884)

Why change this? just a mistake?

This revision now requires changes to proceed.Oct 18 2018, 6:32 PM
shubham added inline comments.
kstars/skycomponents/earthshadowcomponent.cpp
1 ↗(On Diff #43884)

Add copyright header

kstars/skyobjects/ksearthshadow.cpp
1 ↗(On Diff #43884)

Add copyright header

kstars/tools/approachsolver.cpp
1 ↗(On Diff #43884)

Add copyright header

kstars/tools/eclipsehandler.cpp
1 ↗(On Diff #43884)

Add copyright header

kstars/tools/eclipsestool.h
1 ↗(On Diff #43884)

Add copyright header

kstars/tools/eclipsetool.cpp
1 ↗(On Diff #43884)

Add copyright header

kstars/tools/eclipsetool/lunareclipsehandler.cpp
1 ↗(On Diff #43884)

Add copyright header

shubham removed a subscriber: shubham.Oct 18 2018, 6:36 PM
vboettcher updated this revision to Diff 43903.Oct 19 2018, 8:29 AM

Fixed CMakeLists.txt
Add copyright

vboettcher edited the summary of this revision. (Show Details)Oct 19 2018, 8:33 AM
mutlaqja accepted this revision.Oct 19 2018, 7:31 PM
This revision is now accepted and ready to land.Oct 19 2018, 7:31 PM
This revision was automatically updated to reflect the committed changes.