Differential D16267

[Extractor] Improve commandline debugging, forward stderr
ClosedPublic
Actions

Authored by bruns on Oct 17 2018, 1:56 AM.

Details

Reviewers
poboiko
ngraham
Group Reviewers
Baloo
Frameworks
Commits
R293:5ce6e8718bab: [Extractor] Improve commandline debugging, forward stderr
Summary

In case baloo_file is started from an interactive shell/tty, the debug
output no longer goes to the syslog/journal, but to stderr. Make sure
stderr does not end up in the stdin of the parent process but is forwarded.

Test Plan

start baloo_file from the shell, with debugging enabled:
QT_LOGGING_RULES='org.kde.baloo=true' PATH=./bin ./bin/baloo_file
-> debug output from the extractor appears on stderr

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 17 2018, 1:56 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 17 2018, 1:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 17 2018, 1:56 AM
ngraham accepted this revision.Oct 17 2018, 1:59 AM

Yep, nice.

This revision is now accepted and ready to land.Oct 17 2018, 1:59 AM
Closed by commit R293:5ce6e8718bab: [Extractor] Improve commandline debugging, forward stderr (authored by bruns). · Explain WhyOct 17 2018, 2:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/extractorprocess.cpp (1 line)

Diff 43776

View Options

src/file/extractorprocess.cpp

Loading...