Use correct wording, since it is an action word(not a noun)
AbandonedPublic

Authored by shubham on Oct 16 2018, 6:00 PM.

Details

Reviewers
ngraham
ivan
Group Reviewers
Plasma

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
shubham created this revision.Oct 16 2018, 6:00 PM
Restricted Application added a subscriber: plasma-devel. ยท View Herald TranscriptOct 16 2018, 6:00 PM
shubham requested review of this revision.Oct 16 2018, 6:00 PM
ngraham requested changes to this revision.Oct 16 2018, 6:06 PM
ngraham added a subscriber: ngraham.

Actually, the original wording is correct--or at least more correct.

"popup" is a noun, something that can be closed, so "Close popup" is fine. "Close Pop Up" is not correct, because "Pop Up" is a verb construction: "Pop up that thing, will ya?"

The only thing that we could maybe do here is change "popup" to "pop-up", but we would want to first decide on a standardized form, codify it in the HIG (http://hig.kde.org/), and then change it everywhere, not just here.

This revision now requires changes to proceed.Oct 16 2018, 6:06 PM
ivan requested changes to this revision.Oct 16 2018, 6:07 PM
ivan added a subscriber: ivan.

It is (also) a noun, though MW spells it as "pop-up" [1]

[1] https://www.merriam-webster.com/dictionary/pop-up

edit: Heh, Nate was faster :)

shubham abandoned this revision.Oct 16 2018, 6:10 PM